Added Atan2Op support #1056
Open
Added Atan2Op support #1056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmitrovicTT
requested review from
jnie-TT,
kmabeeTT,
AleksKnezevic,
pilkicTT,
svuckovicTT,
rpavlovicTT,
sdjordjevicTT,
mtopalovicTT,
jserbedzijaTT,
nobradovictt,
nsmithtt,
mrakitaTT and
tapspatel
as code owners
AleksKnezevic
approved these changes
Oct 24, 2024
…n. Added ttir to ttnn conversion. Added tests.
kmitrovicTT
force-pushed
the
kmitrovic/stable_hlo_atan2
branch
from
ac2d372
to
93d1814
Compare
|
Seems like Blocked by #1113 |
svuckovicTT
reviewed
Oct 28, 2024
| @@ -1,6 +1,6 @@ | |||
| include(ExternalProject) | |||
|
|
|||
| set(TT_METAL_VERSION "047cdd97fa26b229208ce2f6f8b149c3df277be0") | |||
| set(TT_METAL_VERSION "fccd6929c7a065b9145af92b1a429b2e8f63907b") | |||
There was a problem hiding this comment.
Not sure if this was intentional, or just got picked up during git add. Leaving comment as a reminder to remove before merging.
kmitrovicTT
added
the
MLIR Ops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1204
Added Atan2Op to TTIR and TTNN ops. Added stablehlo to ttir conversion. Added ttir to ttnn conversion. Added tests.